Merged
Conversation
040cfdb to
8b67ead
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for OIDC (OpenID Connect) and SSO (Single Sign-On) integration via oauth2-proxy, including configuration examples, endpoints, and documentation. It adds new endpoints for OIDC discovery and JWKS, provides a complete Docker Compose example for securing apps with Atom as an SSO provider, and updates dependencies to support OIDC and SAML features.
OIDC & SSO Integration:
/.well-known/openid-configuration) and JWKS (/.well-known/jwks.json) endpoints at both root and API paths, allowing external oauth2-proxy and other OIDC clients to discover and verify Atom's authentication capabilities. [1] [2] [3] [4]Deployment and Usage Documentation:
docker-compose.proxy-example.ymlwith example configurations for protecting multiple applications (Grafana, Sonarr, Radarr) using oauth2-proxy as a sidecar, demonstrating best practices for SSO integration with Atom.docs/QUICK_SETUP.md) covering prerequisites, OAuth client creation, environment variable usage, production tips, troubleshooting, and extending protection to additional apps.Dependency Updates:
package.jsonfor OIDC and SAML support, includingjsonwebtoken,node-jose,samlify, andxml-crypto. Also updated development dependencies for type support. [1] [2]Database Migration Utility:
scripts/migrate_tags.js) to add atagscolumn to theuserstable, improving user metadata extensibility.